Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update import file path to handle aliased children #814

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

rtpascual
Copy link
Contributor

@rtpascual rtpascual commented Dec 2, 2022

Issue #, if available:

Description of changes:

  • Handles aliased children which would otherwise share the same name as primitives.
  • Change import file path to point to source component of aliased child.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rtpascual rtpascual force-pushed the fix-aliased-children branch from aeb6efd to 053cd9d Compare December 2, 2022 03:06
@codecov-commenter
Copy link

Codecov Report

Merging #814 (053cd9d) into main (aa92f84) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   91.53%   91.54%           
=======================================
  Files         102      102           
  Lines        4113     4117    +4     
  Branches     1171     1173    +2     
=======================================
+ Hits         3765     3769    +4     
  Misses        327      327           
  Partials       21       21           
Impacted Files Coverage Δ
...-react/lib/amplify-ui-renderers/customComponent.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa92f84...053cd9d. Read the comment docs.

@rtpascual rtpascual marked this pull request as ready for review December 2, 2022 03:24
@rtpascual rtpascual requested a review from a team as a code owner December 2, 2022 03:24
@rtpascual rtpascual merged commit ffe7659 into main Dec 8, 2022
@rtpascual rtpascual deleted the fix-aliased-children branch December 8, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants